Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: add useStore function (#1736) #1739

Merged
merged 1 commit into from
Apr 30, 2020
Merged

types: add useStore function (#1736) #1739

merged 1 commit into from
Apr 30, 2020

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Apr 30, 2020

fix #1736

This PR adds missing useStore function typings. Users may provide State as a generics, or use without it to get Store<any> type.

@kiaking kiaking added bug Something isn't working types Related to typings only labels Apr 30, 2020
@kiaking kiaking requested a review from ktsn April 30, 2020 12:53
@kiaking kiaking self-assigned this Apr 30, 2020
@kiaking kiaking linked an issue Apr 30, 2020 that may be closed by this pull request
useStore is missing a type declaration #1736
Closed
@kiaking kiaking added the 4.x label Apr 30, 2020
ktsn
ktsn approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@ktsn ktsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ktsn ktsn merged commit a934da9 into 4.0 Apr 30, 2020
@ktsn ktsn deleted the 1736-add-usestore-typing branch April 30, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees

@kiaking kiaking

Labels
4.x bug Something isn't working types Related to typings only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

useStore is missing a type declaration
2 participants
@kiaking @ktsn