Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(plugin-watermark): optimize watermark redraw when switching pages #117

Merged
merged 8 commits into from
May 7, 2024

Conversation

pengzhanbo
Copy link
Member

@pengzhanbo pengzhanbo commented May 7, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

  • Optimizing the display of watermarks when switching pages:

    • Transition from a page with a watermark to a page without a watermark.
    • Transition between two different watermark pages.
  • Adding default watermark presets.

@coveralls
Copy link

coveralls commented May 7, 2024

Pull Request Test Coverage Report for Build 8989481347

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.304%

Totals Coverage Status
Change from base Build 8981834307: 0.0%
Covered Lines: 698
Relevant Lines: 1255

💛 - Coveralls

@Mister-Hope
Copy link
Member

I try to fix the globalAlpha and other impack you introduce, you may have a deeper check before we merge it.

@pengzhanbo
Copy link
Member Author

I try to fix the globalAlpha and other impack you introduce, you may have a deeper check before we merge it.

It's OK.

@Mister-Hope Mister-Hope merged commit 080fa20 into vuepress:main May 7, 2024
16 checks passed
@pengzhanbo pengzhanbo deleted the watermark branch May 7, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants