Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: move the <pre> extra attribute to preWrapper #162

Merged
merged 2 commits into from
May 28, 2024
Merged

perf: move the <pre> extra attribute to preWrapper #162

merged 2 commits into from
May 28, 2024

Conversation

pengzhanbo
Copy link
Member

@pengzhanbo pengzhanbo commented May 28, 2024

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

- <div class="language-*">
-   <pre class="shiki nord vp-code" style="background-color:#2e3440ff;color:#d8dee9ff" tabindex="0">

+ <div class="language-*" style="background-color:#2e3440ff;color:#d8dee9ff" tabindex="0">
+   <pre class="shiki nord vp-code">

@coveralls
Copy link

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9268209463

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 56.469%

Totals Coverage Status
Change from base Build 9265804820: 0.08%
Covered Lines: 994
Relevant Lines: 1574

💛 - Coveralls

@@ -257,6 +257,26 @@ div[class*='language-'] {
}
}

// ------------ plugin-shiki code highlighting ------------
// when defaultColor is `false`, override the background color
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

哦我想起来了,我认为这东西默认值最好就是false。另外如果只设置theme而非themes,这个选项是不是没有作用?

@Mister-Hope Mister-Hope merged commit d0bc473 into main May 28, 2024
32 checks passed
@Mister-Hope Mister-Hope deleted the shiki branch May 28, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants