Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-default): code block line number misalignment in Safari #164

Merged
merged 1 commit into from
May 29, 2024

Conversation

pengzhanbo
Copy link
Member

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

The height of .line-number should be calculated based on the font-size and line-height of .line-numbers, rather than being directly set to {line-height}em, as this could lead to rendering issues.

 .line-number {
   ...
-  height: #{$line-height}em;
 }

@coveralls
Copy link

Pull Request Test Coverage Report for Build 9280098507

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 56.469%

Totals Coverage Status
Change from base Build 9273639561: 0.0%
Covered Lines: 994
Relevant Lines: 1574

💛 - Coveralls

@Mister-Hope Mister-Hope changed the title fix: code block line number misalignment in Safari fix(theme-default): code block line number misalignment in Safari May 29, 2024
@Mister-Hope Mister-Hope enabled auto-merge (squash) May 29, 2024 04:29
@Mister-Hope Mister-Hope merged commit 16f9024 into main May 29, 2024
32 checks passed
@Mister-Hope Mister-Hope deleted the fix-code-line-height branch May 29, 2024 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants