Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for word highlight #201

Merged
merged 6 commits into from
Jun 10, 2024
Merged

feat: add support for word highlight #201

merged 6 commits into from
Jun 10, 2024

Conversation

pengzhanbo
Copy link
Member

@pengzhanbo pengzhanbo commented Jun 7, 2024 •
edited
Loading

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Provide a description in this PR that addresses what the PR is solving. If this PR is going to solve an existing issue, please reference the issue (e.g. close #123).

What is the purpose of this pull request?

  • Bug fix
  • New feature
  • Other

Description

  • plugin-prismjs
  • plugin-shiki

Screenshots

image

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410381484

Details

  • 60 of 61 (98.36%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.829%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410415806

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.829%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410484542

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 56.798%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.6%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410484475

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 56.798%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.6%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9410837112

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@Mister-Hope
Copy link
Member

could [word] be better?

@pengzhanbo
Copy link
Member Author

could [word] be better?

No, this is a feature that aligns with the Shiki Word Highlight. On one hand, it ensures consistent input and output results when both plugins are utilizing this feature. On the other hand, it should maintain the same style as other features such as focus, diff, and so on.

Mister-Hope
Mister-Hope previously approved these changes Jun 7, 2024
View reviewed changes
@pengzhanbo @Mister-Hope
chore: tweak
d5866a3 
Co-authored-by: Mister-Hope <mister-hope@outlook.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 7, 2024

Pull Request Test Coverage Report for Build 9417820672

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9417820672

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9417857347

Details

  • 59 of 60 (98.33%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.7%) to 56.818%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/markdown/plugin-prismjs/src/node/parser/createNotationRule.ts 13 14 92.86%
Totals Coverage Status
Change from base Build 9381003398: 0.7%
Covered Lines: 1025
Relevant Lines: 1615
💛 - Coveralls

@Mister-Hope Mister-Hope merged commit 6f37277 into main Jun 10, 2024
32 checks passed
@Mister-Hope Mister-Hope deleted the word-highlight branch June 10, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mister-Hope Mister-Hope Mister-Hope left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pengzhanbo @coveralls @Mister-Hope