Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add slimsearch plugin #288

Merged
merged 26 commits into from
Nov 21, 2024
Merged

feat: add slimsearch plugin #288

merged 26 commits into from
Nov 21, 2024

Conversation

Mister-Hope
Copy link
Member

No description provided.

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for vuepress-ecosystem ready!

Name Link
🔨 Latest commit 9ec7836
🔍 Latest deploy log https://app.netlify.com/sites/vuepress-ecosystem/deploys/673efa946b822e0008b116c5
😎 Deploy Preview https://deploy-preview-288--vuepress-ecosystem.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11950150083

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 96 of 115 (83.48%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.6%) to 60.035%

Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/search/plugin-slimsearch/src/node/pathStore.ts 5 11 45.45%
plugins/search/plugin-slimsearch/src/node/generateIndex.ts 60 73 82.19%
Totals Coverage Status
Change from base Build 11950144997: 1.6%
Covered Lines: 1305
Relevant Lines: 1970

💛 - Coveralls

@Mister-Hope Mister-Hope marked this pull request as ready for review November 18, 2024 13:39
@Mister-Hope Mister-Hope enabled auto-merge (squash) November 18, 2024 14:05
@pengzhanbo
Copy link
Member

It is recommended to adjust the minimum height of the modal box. The height change from Searching... to No results found after inputting content causes the modal box to shake.

@Mister-Hope
Copy link
Member Author

Could you please provide screenshots or just fix it for me?

also you can check the implementation. I think improvement could be made on my codes.

@Mister-Hope Mister-Hope merged commit 513bca7 into main Nov 21, 2024
31 checks passed
@Mister-Hope Mister-Hope deleted the plugin-slimsearch branch November 21, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants