Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

feat: support for custom dates #28

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

himself65
Copy link
Contributor

@himself65 himself65 commented Dec 15, 2019

Summary

fix #25, and enhance it.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@himself65
Copy link
Contributor Author

can we add a linter such as eslint? IDE automatically remove useless spaces

@billyyyyy3320
Copy link
Member

@himself65 I've just added the linter.👌

@himself65
Copy link
Contributor Author

@himself65 I've just added the linter.👌
that's great

@billyyyyy3320
Copy link
Member

It shows invalid date In Safari. Have you considered leveraging dayjs instead of moment? It's more light-weight and it might resolve the bug.

@himself65 himself65 force-pushed the date branch 2 times, most recently from 8f69a3e to 4e35b6c Compare December 21, 2019 04:03
@himself65
Copy link
Contributor Author

ok, I will try that

docs/README.md Outdated Show resolved Hide resolved
Co-Authored-By: Billyyyyy3320 <newsbielt703@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid date
2 participants