Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] v-text-field v-label should not be created when empty "label" prop is passed #18793

Closed
jandrij opened this issue Nov 29, 2023 · 2 comments
Labels
S: stale This issue is untriaged and hasn't seen any activity in at least six months. S: triage

Comments

@jandrij
Copy link

jandrij commented Nov 29, 2023

Problem to solve

In the case when labels have to be outside the v-text-field due to layout requirements accessability issues arise. If you create an outside label and link it to the v-text-field, an issue of multiple labels arise as well as having an emtpy label sitting there.

Proposed solution

Check if hasLabel.value is not empty before creating the VFieldLabel here: https://github.com/vuetifyjs/vuetify/blob/a47ec9af018693bc95d06304521fe04ca8bf40b5/packages/vuetify/src/components/VField/VField.tsx#L296C1-L298C27

@websitevirtuoso
Copy link
Contributor

Does it make sense? what MDI specification says about it?

@websitevirtuoso
Copy link
Contributor

If you provode that this is really importan and give more details. I will be happy to help and even create PR

@github-actions github-actions bot added the S: stale This issue is untriaged and hasn't seen any activity in at least six months. label Jun 7, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S: stale This issue is untriaged and hasn't seen any activity in at least six months. S: triage
Projects
None yet
Development

No branches or pull requests

2 participants