Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VBtnGroup/VBottomNavigation): Add baseColor prop #19088

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Jan 23, 2024

fixes #17042

Description

Copy "baseColor" logic from VListItem

Markup:

<template>
  <v-card class="mx-auto" max-width="300">
    <v-list :items="items" color="green" base-color="red"></v-list>
  </v-card>
  <br>
  <br>
  <br>
  <v-card class="mx-auto" max-width="300">
    <v-btn-toggle color="green" :base-color="baseColor" v-model="toggle_exclusive">
      <v-btn>
        <v-icon>mdi-format-align-left</v-icon>
      </v-btn>

      <v-btn>
        <v-icon>mdi-format-align-center</v-icon>
      </v-btn>

      <v-btn>
        <v-icon>mdi-format-align-right</v-icon>
      </v-btn>

      <v-btn>
        <v-icon>mdi-format-align-justify</v-icon>
      </v-btn>
    </v-btn-toggle>
    
  </v-card>
  <v-btn
    @click="() => baseColor = 'yellow'"
  >
    change basecolor to yellow
  </v-btn>
</template>

<script>
  export default {
    data: () => ({
      toggle_exclusive: 2,
      baseColor: 'red',
      items: [
        {
          title: 'Item #1',
          value: 1,
        },
        {
          title: 'Item #2',
          value: 2,
        },
        {
          title: 'Item #3',
          value: 3,
        },
      ],
    }),
  }
</script>

@KaelWD KaelWD added this to the v3.6.0 (Nebula) milestone Jan 23, 2024
@yuwu9145 yuwu9145 changed the title feat(VBtnGroup): Add baseColor prop feat(VBtnGroup/VBottomNavigation): Add baseColor prop Jan 24, 2024
@yuwu9145 yuwu9145 marked this pull request as ready for review January 24, 2024 04:22
@yuwu9145 yuwu9145 requested a review from KaelWD January 24, 2024 04:22
@MajesticPotatoe
Copy link
Member

is it a bug fix or a feature?

@yuwu9145 yuwu9145 changed the base branch from master to dev January 25, 2024 03:31
@yuwu9145 yuwu9145 changed the base branch from dev to master January 25, 2024 03:33
@yuwu9145
Copy link
Member Author

yuwu9145 commented Jan 25, 2024

is it a bug fix or a feature?

Small new feature, I will base branch it to dev

@yuwu9145 yuwu9145 changed the base branch from master to dev January 25, 2024 03:45
@johnleider johnleider self-requested a review April 5, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support active-color prop on v-bottom-navigation similar to v-list
4 participants