Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VProgressLinear): Remove will-change to prevent weird visual behaviour #19435

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

yuwu9145
Copy link
Member

fixes #19410

will-change should be used as a last resort to resolve existing performance problem, it's doing strange pre-animation effect in Windows here.

Description

Markup:

<template>
  <v-app>
    <v-container>
      <v-checkbox label="Show Loading" v-model="loading" />
      <v-text-field
        v-model="msg"
        color="blue"
        :loading="loading"
        variant="outlined"
      />
      <div class="h3 mb-2">Temporay Solution</div>
      <v-text-field
        v-model="msg"
        color="blue"
        :loading="loading"
        variant="outlined"
      >
        <template #loader>
          <v-progress-linear
            v-show="loading"
            height="2"
            color="blue"
            indeterminate
          />
        </template>
      </v-text-field>
    </v-container>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'
  const loading = ref(false)
  const msg = ref('Check to show loading')
</script>

@johnleider johnleider added this to the v3.5.x milestone Mar 19, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VProgressLinear labels Mar 19, 2024
@johnleider johnleider merged commit 0167be4 into master Mar 19, 2024
17 of 19 checks passed
@johnleider johnleider deleted the fix-19410 branch March 19, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VProgressLinear T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants