-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VMenu): min width property #19771
Merged
johnleider
merged 6 commits into
vuetifyjs:master
from
elkofy:fix/16987-VOverlay-min-width-not-working
May 21, 2024
Merged
fix(VMenu): min width property #19771
johnleider
merged 6 commits into
vuetifyjs:master
from
elkofy:fix/16987-VOverlay-min-width-not-working
May 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MajesticPotatoe
added
T: bug
Functionality that does not work as intended/expected
C: VMenu
VMenu
labels
May 8, 2024
When no min-width is supplied it's no longer calculates properly. |
fixed I hope It's not the cleanest but works really great and it's the smallest code change I could think of |
Valiant effort but we're going to have to figure out a different way. |
how about this method ? |
johnleider
force-pushed
the
fix/16987-VOverlay-min-width-not-working
branch
from
May 21, 2024 15:20
88470d7
to
43683ca
Compare
johnleider
requested review from
KaelWD and
johnleider
and removed request for
KaelWD
May 21, 2024 15:35
johnleider
approved these changes
May 21, 2024
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I switched the dimensionsStyle and contentStyle since the first one gets overrided by the second.Hence I provided a much simpler solution that what was proposed originally.
fixes #16987
Markup: