Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VMenu): min width property #19771

Merged

Conversation

elkofy
Copy link
Contributor

@elkofy elkofy commented May 7, 2024

Description

I switched the dimensionsStyle and contentStyle since the first one gets overrided by the second.Hence I provided a much simpler solution that what was proposed originally.
fixes #16987

Markup:

<template>
  <v-app>
    <div class="text-center">
      <v-menu :min-width="500">
        <template #activator="{ props }">
          <v-btn v-bind="props">
            Dropdown
          </v-btn>
        </template>
        <v-list>
          <v-list-item>
            <v-list-item-title>Here</v-list-item-title>
          </v-list-item>
        </v-list>
      </v-menu>
    </div>
  </v-app>
</template>

<script setup>
  import { ref } from 'vue'
</script>

@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VMenu VMenu labels May 8, 2024
@johnleider johnleider added this to the v3.6.x milestone May 14, 2024
@johnleider
Copy link
Member

johnleider commented May 14, 2024

When no min-width is supplied it's no longer calculates properly.

@elkofy
Copy link
Contributor Author

elkofy commented May 15, 2024

When no min-width is supplied it's no longer calculates properly.

fixed I hope It's not the cleanest but works really great and it's the smallest code change I could think of

@johnleider
Copy link
Member

Valiant effort but we're going to have to figure out a different way.

@elkofy
Copy link
Contributor Author

elkofy commented May 17, 2024

Valiant effort but we're going to have to figure out a different way.

how about this method ?

@johnleider johnleider force-pushed the fix/16987-VOverlay-min-width-not-working branch from 88470d7 to 43683ca Compare May 21, 2024 15:20
@johnleider johnleider requested review from KaelWD and johnleider and removed request for KaelWD May 21, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VMenu VMenu T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.1.11] v-menu min-width property does not work
3 participants