-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VOverlay): App mounted in shadow dom #19947
fix(VOverlay): App mounted in shadow dom #19947
Conversation
@MajesticPotatoe I might need a poke in right direction here to perfect this one. Because there is some css-issues still. For example in my repro I use a v-select. The items in the v-select gets dark background color and with darkened text. So there is some more to throw at this one. |
@joelmandell
Just want to let you know. 😉 |
Description
This checks if the target of VOverlay is an shadow dom element and attaches it to that one. This fixes issues when mounting app on shadow dom. This fixes #19943
Markup:
Playground is not provided because this is setup in a different way, it can be examined by the repro here:
https://github.com/joelmandell/shadow_dom
Without applying this PR, v-overlay-container will be attached outside the shadow dom and not working correctly.