Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report][3.7.4] Readonly Form is inconsistent when inputs have readonly false #20730

Closed
charlesg99 opened this issue Nov 24, 2024 · 3 comments
Assignees
Labels
C: VForm VForm C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Milestone

Comments

@charlesg99
Copy link

Environment

Vuetify Version: 3.7.4
Vue Version: 3.5.13
Browsers: Chrome 131.0.0.0
OS: Linux x86_64

Steps to reproduce

Set a form to readonly with its readonly attribute. Set readonly to false to inputs within the form.

Expected Behavior

All inputs within the form are readonly

Actual Behavior

All inputs aren't readonly, you can still edit the textfield

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

Seems like some work was done for selects in #16161. Probably need the same fix for textfields.

@MatthewAry MatthewAry added T: bug Functionality that does not work as intended/expected layer 8 issue C: VForm VForm C: VTextField VTextField labels Nov 26, 2024
@MatthewAry
Copy link
Contributor

MatthewAry commented Nov 26, 2024

The expected behavior should be that all inputs with the :readonly="false" prop applied, in contradiction to the :readonly="true" property set in VForm, should be editable. VSelect is not working correctly.

@charlesg99
Copy link
Author

I feel like the other way around would be more helpful, but I agree that a child should have the last say. If the resolution makes it that all child inputs have the same behavior, that's a win.

@KaelWD
Copy link
Member

KaelWD commented Nov 27, 2024

Null or undefined will cause it to inherit from the form, if it's coming from an expression you can use :readonly="expr || null".

@KaelWD KaelWD self-assigned this Nov 27, 2024
@KaelWD KaelWD added this to the v3.7.x milestone Nov 27, 2024
@KaelWD KaelWD closed this as completed in b7df7f0 Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VForm VForm C: VSelect VSelect T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

3 participants