-
-
Notifications
You must be signed in to change notification settings - Fork 7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VDivider): port to v3 #12993
feat(VDivider): port to v3 #12993
Conversation
Requesting Initial comments from @vuetifyjs/contributors @vuetifyjs/core-team |
packages/vuetify/src/components/VDivider/__tests__/__snapshots__/VDivider.spec.ts.snap
Show resolved
Hide resolved
c8b6ea6
to
19a6d5f
Compare
Requesting Final comments from @vuetifyjs/contributors @vuetifyjs/core-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not entirely on board with the current API of v-divider. Assuming everything works correctly, the following markup
<v-divider width="100px" height="100px" border></v-didiver>
Would result in a 100x100px box with border on all sides. That seems very far from what v-divider
should be and do.
Additionally, markup like this
<v-divider width="100px"></v-divider>
Would result in something like this in horizontal mode
And this in vertical mode
since width/height are orientation dependent.
In my mind, the props
border
width
height
maxWidth
maxHeight
could be replaced by
thickness
length
color (if we want to keep that functionality from border)
and better represent the function of the component
packages/vuetify/src/components/VDivider/__tests__/VDivider.spec.ts
Outdated
Show resolved
Hide resolved
implemented feedback from review
replace with 2 new properties, length and thickness
639255c
to
3e6a499
Compare
Co-authored-by: Albert Kaaman <albert@kaaman.nu>
Description
More to follow..
fixes #12054
Motivation and Context
Port v-divider to v3
How Has This Been Tested?
jest
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and backwards compatible changes andnext
for non-backwards compatible changes).