Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(VDialog): make form fill parent #20555

Merged
merged 5 commits into from
Nov 6, 2024
Merged

fix(VDialog): make form fill parent #20555

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
493c4b4
fix(VDialog): make form always fill parent
Jesse205 Oct 3, 2024
8b15436
Revert "fix(VDialog): add height to form in fullscreen dialog (#20417)"
Jesse205 Oct 3, 2024
5c0f11f
Merge branch 'master' into fix-dialog-form-fill
KaelWD Nov 6, 2024
444514b
expand existing flex rules
KaelWD Nov 6, 2024
5164146
flex cards
KaelWD Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions packages/vuetify/src/components/VDialog/VDialog.sass
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
--v-scrollbar-offset: 0px
border-radius: $dialog-border-radius
overflow-y: auto
flex: 1 1 100%

@include tools.elevation($dialog-elevation)

Expand Down Expand Up @@ -54,6 +55,7 @@
margin: 0
padding: 0
width: 100%
height: 100%
max-width: 100%
max-height: 100%
overflow-y: auto
Expand All @@ -62,8 +64,6 @@

&,
> form
height: 100%

> .v-card,
> .v-sheet
min-height: 100%
Expand All @@ -73,15 +73,14 @@
.v-dialog--scrollable > .v-overlay__content
&,
> form
display: flex

&,
> .v-card
display: flex
flex: 1 1 100%
flex-direction: column
max-height: 100%
max-width: 100%

> .v-card-text
backface-visibility: hidden
overflow-y: auto
> .v-card > .v-card-text
backface-visibility: hidden
overflow-y: auto