-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat-req] Add height preset #37
Comments
Hello :) Thanks for the suggestion! Could you provide examples of usage? I would love to review a PR on that! Let me know if anything is needed! |
Hi, Thanks for the response. Height preset will allow creating components like collapse easily. Generally, when I want to create collapse I use The reason I didn't do it myself is I don't know much about animation and more specifically I don't have much experience in vue animation via JS. Also, animating height is a bad idea to achieve 60fps smooth animation so experts might know how to achieve smooth animation for things like collapse. Example of BSV: https://bootstrap-vue.org/docs/components/collapse |
I am really sorry for the late answer. I am looking forward to implement something like you mentioned (I understand the will to have a similar approach as That will be made possible by |
Hey! 👋🏻 With this kind of variant? {
initial: {
opacity: 0,
height: 0
},
enter: {
opacity: 1,
height: "auto"
}
} Right now, |
@handhikadj I know that sine other do but I don't want to bring the big guns/have something external. |
@kissu, could you post what your solution was so that others have an idea in the meantime? |
@SelfhostedPro I pretty much used a blend between the 2 techniques described here. Really depends on your use-case but fixing it with CSS-only is probably the best way. This one may also be quite useful depending on the browsers you need to support. |
I achieved this with
|
Hi,
I was checking the preset docs page of this package. I guess, adding a height preset will be great for people who want to create a collapse component.
This is useful in cases like: FAQ, QnA, Custom Collapse, etc.
Regards.
The text was updated successfully, but these errors were encountered: