Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware can't alter a response when there isn't one. #67

Open
jbardin opened this issue Sep 4, 2014 · 0 comments
Open

Middleware can't alter a response when there isn't one. #67

jbardin opened this issue Sep 4, 2014 · 0 comments

Comments

@jbardin
Copy link
Contributor

jbardin commented Sep 4, 2014

If the request.Attempt failed (i.e. upstream is unavailable), there is no response, and no way for the middleware to communicate back to the client.

It would be nice to be able to return an error page other than {"error":"Bad Gateway"}, but we can't without access to a Response or something that can write to the http.ResponseWriter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jbardin