Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.RequesURI is empty #68

Open
klizhentas opened this issue Sep 18, 2014 · 2 comments
Open

request.RequesURI is empty #68

klizhentas opened this issue Sep 18, 2014 · 2 comments

Comments

@klizhentas
Copy link
Contributor

We erase request.RequestURI in favor of Opaque data, but this makes access to URL.Query() impossible as it returns empty results.

@marbemac
Copy link

@klizhentas Just came here to post this issue, and saw it was put up for discussion a few months ago. Any thoughts on not erasing URL.RawQuery on this line? As you mention, it breaks URL.Query().

https://github.com/mailgun/vulcan/blob/master/location/httploc/httploc.go#L305

@marbemac
Copy link

In addition, overwriting URL.Opaque in line 303 of httploc seems to mess with URL.Host (and thus URL.String()). Could be specific to my setup, but printing URL.String() after Opaque is overwritten prints with a blank host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants