Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should AllocateDescriptorSets take []DescriptorSet rather than *DescriptorSet? #35

Open
Noofbiz opened this issue Jan 1, 2019 · 2 comments
Labels

Comments

@Noofbiz
Copy link

Noofbiz commented Jan 1, 2019

Like how CommandBuffers or other ones that have plural names, they generally take a slice rather than a pointer. It's possible to do it this way in Vulkan in C++ as follows

std::vector<VkDescriptorSet> descriptorSets;
vkAllocateDescriptorSets(device, &allocInfo, descriptorSets.data());
@xlab
Copy link
Member

xlab commented Jan 2, 2019

Yes, in most cases the difference between a reference and an array is not clear to the automated conveter. So it must be specified in the manifest — https://github.com/vulkan-go/vulkan/blob/master/vulkan.yml

@celer
Copy link

celer commented Dec 31, 2019

+1

@xlab xlab added the bug label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants