Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport extent documentation and examples are wrong. #2583

Closed
coolcatcoder opened this issue Oct 20, 2024 · 0 comments · Fixed by #2584
Closed

Viewport extent documentation and examples are wrong. #2583

coolcatcoder opened this issue Oct 20, 2024 · 0 comments · Fixed by #2584

Comments

@coolcatcoder
Copy link
Contributor

coolcatcoder commented Oct 20, 2024

Run triangle-util and resize the window. The triangle doesn't move. This is because the viewport is never updated.

I originally wrote the triangle-util example, so this is probably my fault, but I'd also like to drag Viewport's documentation down with me. Specifically the documentation of its field called extent. Extent's documentation is: "Dimensions in pixels of the viewport. The default value is [1.0; 2], which you probably want to override if you are not using dynamic state.". Even with dynamic viewport enabled you still need to override the default.

The documentation should be changed, and the example fixed. (Should also check to see if any other examples suffer from this.)

@coolcatcoder coolcatcoder changed the title Dynamic viewport documentation and examples are wrong. Viewport extent documentation and examples are wrong. Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant