Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Don't allow "container-registry credentials docker" without providing registry UUID #498

Open
benok opened this issue Dec 4, 2024 · 1 comment · May be fixed by #506
Open

[BUG] - Don't allow "container-registry credentials docker" without providing registry UUID #498

benok opened this issue Dec 4, 2024 · 1 comment · May be fixed by #506
Labels
bug Something isn't working

Comments

@benok
Copy link

benok commented Dec 4, 2024

Hi, I found another one like #497.

Describe the bug
When running container-registry credentials docker and not including a UUID

$ vultr-cli container-registry credentials docker
panic: runtime error: index out of range [0] with length 0

goroutine 1 [running]:
github.com/vultr/vultr-cli/v3/cmd/containerregistry.(*options).credentialsDocker(0xc00011a200?)
        github.com/vultr/vultr-cli/v3/cmd/containerregistry/containerregistry.go:713 +0x65
github.com/vultr/vultr-cli/v3/cmd/containerregistry.NewCmdContainerRegistry.func20(0xc000117808, {0xdf9840?, 0x4?, 0x98edea?})
        github.com/vultr/vultr-cli/v3/cmd/containerregistry/containerregistry.go:597 +0x1bc
github.com/spf13/cobra.(*Command).execute(0xc000117808, {0xdf9840, 0x0, 0x0})
        github.com/spf13/cobra@v1.8.1/command.go:985 +0xaca
github.com/spf13/cobra.(*Command).ExecuteC(0xd92f80)
        github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
        github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/vultr/vultr-cli/v3/cmd.Execute()
        github.com/vultr/vultr-cli/v3/cmd/root.go:64 +0x1a
main.main()
        github.com/vultr/vultr-cli/v3/main.go:7 +0xf

Expected behavior
Make the UUID required

@benok benok added the bug Something isn't working label Dec 4, 2024
@kanha-gupta
Copy link

I am raising a PR for this

@kanha-gupta kanha-gupta linked a pull request Jan 26, 2025 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants