You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If a user doesn't have access to read some registry keys, they can get a synchronous error, which is unhandled, and which thus crashes the process. See httptoolkit/httptoolkit#50 for an example.
Imo, in this case we should just ignore the information from that registry key, and move on, rather than failing entirely. It's safe to do so I believe, it just reduces the amount of info (e.g. uninstaller paths) we can return.
I'm happy to open a PR for this, just checking it would be welcomed first. My suggestion would be to just change enumerateValues to enumerateValuesSafe, which automatically returns [] if any registry values can't be read. I've given this a quick test locally and it seems to work very nicely, and still detects other browser info as normal. Sound good?
The text was updated successfully, but these errors were encountered:
If a user doesn't have access to read some registry keys, they can get a synchronous error, which is unhandled, and which thus crashes the process. See httptoolkit/httptoolkit#50 for an example.
Imo, in this case we should just ignore the information from that registry key, and move on, rather than failing entirely. It's safe to do so I believe, it just reduces the amount of info (e.g. uninstaller paths) we can return.
I'm happy to open a PR for this, just checking it would be welcomed first. My suggestion would be to just change
enumerateValues
toenumerateValuesSafe
, which automatically returns[]
if any registry values can't be read. I've given this a quick test locally and it seems to work very nicely, and still detects other browser info as normal. Sound good?The text was updated successfully, but these errors were encountered: