Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Data Loading: Move first Camera to Origin #18

Open
smueksch opened this issue Jun 8, 2023 · 0 comments
Open

Camera Data Loading: Move first Camera to Origin #18

smueksch opened this issue Jun 8, 2023 · 0 comments

Comments

@smueksch
Copy link

smueksch commented Jun 8, 2023

I have a question about the meaning of a particular code snippet in the CameraData.load_data function, lines 325-237:

t0 = -cam_t[sidx:sidx+1] + torch.randn(3) * 0.1
self.cam_R = cam_R[sidx:eidx]
self.cam_t = cam_t[sidx:eidx] - t0

My understanding is that cam_R and cam_t together form the world-2-cam matrix, so cam_t does not represent the position of the camera in world coordinates. Given this, I am confused what this code snippet really is meant to do and if this is not a bug in the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant