Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: Remove RLPList #1866

Closed
iamdefinitelyahuman opened this issue Feb 29, 2020 · 3 comments
Closed

VIP: Remove RLPList #1866

iamdefinitelyahuman opened this issue Feb 29, 2020 · 3 comments
Labels
VIP: Approved VIP Approved

Comments

@iamdefinitelyahuman
Copy link
Contributor

Simple Summary

Remove the builtin RLPList function.

Motivation

My understanding is that this function was put in place for, and served a very specific purpose related to the ETH 2.0 deposit contract. With a specific version of Vyper forked, verified and frozen for said contract, I see no need to keep this function as a part of the language.

Specification

  1. Remove RLPList from vyper/functions
  2. Remove the test cases
  3. Remove the section in the documentation

Backwards Compatibility

It is a breaking change, but I highly doubt it will affect any existing projects.

Copyright

Copyright and related rights waived via CC0

@fubuloubu
Copy link
Member

I see this change overall as good, because the RLP decoder is really not what most people want, rather they want #1406. So, this change should come after we finish that one.

@fubuloubu fubuloubu added the VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting label Feb 29, 2020
@fubuloubu fubuloubu mentioned this issue Feb 29, 2020
3 tasks
@jacqueswww
Copy link
Contributor

jacqueswww commented Mar 2, 2020

Approved; should be replaced by ABI - encoder / decoder.

RLP List isn't necessary anymore; and its a very error-prone part of the codebase.

@jacqueswww jacqueswww added the VIP: Approved VIP Approved label Mar 2, 2020
@fubuloubu fubuloubu removed the VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting label Mar 2, 2020
@fubuloubu fubuloubu added this to the v0.2 Release milestone Jun 21, 2020
@iamdefinitelyahuman
Copy link
Contributor Author

Closed by #1872 and #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VIP: Approved VIP Approved
Projects
None yet
Development

No branches or pull requests

3 participants