Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP: Change public and private keywords to external and internal #2065

Closed
fubuloubu opened this issue Jun 28, 2020 · 0 comments · Fixed by #2073
Closed

VIP: Change public and private keywords to external and internal #2065

fubuloubu opened this issue Jun 28, 2020 · 0 comments · Fixed by #2073
Assignees
Labels
VIP: Approved VIP Approved

Comments

@fubuloubu
Copy link
Member

Simple Summary

Change public and private keywords to external and internal

Motivation

private is a confusing keyword for newcomers, as it doesn't mean what it should in typical contexts. Also, our use of public is more consistent with Solidity's external modifier, as we do additional checks, so it makes sense to change that too

Specification

Just change the decorators

Backwards Compatibility

This would not be backwards compatible

Dependencies

No dependencies

References

No references

Copyright

Copyright and related rights waived via CC0

@iamdefinitelyahuman iamdefinitelyahuman added the VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting label Jun 28, 2020
@fubuloubu fubuloubu added VIP: Approved VIP Approved and removed VIP: Discussion Used to denote VIPs and more complex issues that are waiting discussion in a meeting labels Jun 29, 2020
@iamdefinitelyahuman iamdefinitelyahuman added this to the v0.2.0 Release milestone Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
VIP: Approved VIP Approved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants