Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc out of date #2448

Closed
benjiqq opened this issue Sep 3, 2021 · 3 comments
Closed

doc out of date #2448

benjiqq opened this issue Sep 3, 2021 · 3 comments

Comments

@benjiqq
Copy link
Contributor

benjiqq commented Sep 3, 2021

lastest vyper

this doesn't compile
https://vyper.readthedocs.io/en/stable/built-in-functions.html#data-manipulation

@external
@view
def foo(a: String[5], b: String[5], c: String[5]) -> String[100]
    return concat(a, " ", b, " ", c, "!")

InvalidType: Reason must UNREACHABLE or a string literal

@charles-cooper
Copy link
Member

looks like it's missing a semicolon

@external
@view
def foo(a: String[5], b: String[5], c: String[5]) -> String[100]:
    return concat(a, " ", b, " ", c, "!")
(vyper) ~/vyper $ vyper repros/2448.vy 
0x61023656600436101561000d57610227565b600035601c526000513461022d5763a71335c8811415610225576025600435600401610140376005600435600401351161022d5760256024356004016101a0376005602435600401351161022d576025604435600401610200376005604435600401351161022d57600061014060058060208461038001018260208501600060045af15050805182019150506001610260527f20000000000000000000000000000000000000000000000000000000000000006102805261026060018060208461038001018260208501600060045af15050805182019150506101a060058060208461038001018260208501600060045af150508051820191505060016102c0527f20000000000000000000000000000000000000000000000000000000000000006102e0526102c060018060208461038001018260208501600060045af150508051820191505061020060058060208461038001018260208501600060045af15050805182019150506001610320527f21000000000000000000000000000000000000000000000000000000000000006103405261032060018060208461038001018260208501600060045af1505080518201915050806103805261038090508051602001806104208284600060045af11561022d575050610420518061044001818260206001820306601f82010390500336823750506020610400526040610420510160206001820306601f8201039050610400f35b505b60006000fd5b600080fd5b61000461023603610004600039610004610236036000f3

doc PRs welcome!

@benjiqq
Copy link
Contributor Author

benjiqq commented Sep 3, 2021

#2450

@benjiqq
Copy link
Contributor Author

benjiqq commented Sep 3, 2021

the underlying issue #2449

@benjiqq benjiqq closed this as completed Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants