Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VIP: rename create_forwarder_to to create_minimal_proxy_to #2893

Closed
Tracked by #2857
charles-cooper opened this issue Jun 5, 2022 · 3 comments · Fixed by #2895
Closed
Tracked by #2857

VIP: rename create_forwarder_to to create_minimal_proxy_to #2893

charles-cooper opened this issue Jun 5, 2022 · 3 comments · Fixed by #2895

Comments

@charles-cooper
Copy link
Member

charles-cooper commented Jun 5, 2022 •
edited
Loading

Simple Summary

As title. Rename the builtin create_forwarder_to to create_minimal_proxy_to.

Motivation

In the past, create_forwarder_to was chosen over proxy terminology (see #1177 (comment)). However, I think these days, proxy is a more standard terminology when talking about smart contracts. Plus, the implementation of create_forwarder_to() was changed in #2281 to use EIP-1167 - the terminology in the EIP only mentions "proxies", not "forwarders", so we should be consistent with the EIP terminology.

Specification

Rename create_forwarder_to to create_minimal_proxy_to

Backwards Compatibility

Breaking change

Dependencies

References

Copyright

Copyright and related rights waived via CC0
@fubuloubu
Copy link
Member

There are many different types of proxies, forwarder style proxies are just one kind

@charles-cooper
Copy link
Member Author

There are many different types of proxies, forwarder style proxies are just one kind

the title of EIP 1167 is "Minimal Proxy Contract" - https://eips.ethereum.org/EIPS/eip-1167

@charles-cooper charles-cooper mentioned this issue Jun 5, 2022
Closed
12 tasks
@charles-cooper charles-cooper changed the title VIP: rename create_forwarder_to to create_proxy_to VIP: rename create_forwarder_to to create_minimal_proxy_to Jun 6, 2022
@charles-cooper
Copy link
Member Author

meeting notes: use create_minimal_proxy_to (mirrors EIP1167 terminology)

@charles-cooper charles-cooper mentioned this issue Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: create_from_factory and create_copy_of charles-cooper/vyper
2 participants
@fubuloubu @charles-cooper