Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adopt a new theme? #3746

Closed
BoboTiG opened this issue Jan 24, 2024 · 4 comments · Fixed by #3754
Closed

docs: Adopt a new theme? #3746

BoboTiG opened this issue Jan 24, 2024 · 4 comments · Fixed by #3754

Comments

@BoboTiG
Copy link
Contributor

BoboTiG commented Jan 24, 2024

I would like to propose the usage of another theme for the documentation: shibuya. A preview is visible here: https://shibuya.lepture.com/

Would you be open to such a change?

Previews of the "Built-in Functions" page:
Screenshot 2024-01-24 at 22-51-05 Built-in Functions
Screenshot 2024-01-24 at 22-51-15 Built-in Functions

Personally, I only see pros, but that's will depend on each individual:

  • no more custom CSS (light/dark themes are already provided, same for the toggle)
  • modern design
  • responsive
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 24, 2024

I just saw the logo on dark them is poorly visible. Apart from that, it seems good: I'll find a way for the logo if the proposal is accepted.

@BoboTiG BoboTiG changed the title docs: Adopt a new theme docs: Adopt a new theme? Jan 25, 2024
@charles-cooper
Copy link
Member

i'm interested! is there any way to preview what this would look like?

by the way, we are migrating to new logo -- you can see here https://github.com/vyperlang/vyper-brand/tree/main

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 30, 2024

i'm interested! is there any way to preview what this would look like?

Awesome, I will put something for a preview.

by the way, we are migrating to new logo -- you can see here https://github.com/vyperlang/vyper-brand/tree/main

Awesome too! I'll use it for the preview.

@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 30, 2024

@charles-cooper I shared the preview link directly in the PR (#3754) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants