Skip to content

bytestring equality incorrect for Bytes[N<=32]

Moderate
charles-cooper published GHSA-7vrm-3jc8-5wwm Apr 2, 2022

Package

pip vyper (pip)

Affected versions

<0.3.2

Patched versions

0.3.2

Description

Impact

bytestrings can have dirty bytes in them, resulting in the word-for-word comparison to give incorrect results, e.g.

b1: Bytes[32] = b"abcdef"
b1 = slice(b1, 0, 1)
b2: Bytes[32] = b"abcdef"
t: bool = b1 == b2  # incorrectly evaluates to True

even without dirty nonzero bytes, because there is no comparison of the length, two bytestrings can compare to equal if one ends with "\x00".

b1: Bytes[32] = b"abc\0"
b2: Bytes[32] = b"abc"
t: bool = b1 == b2  # incorrectly evaluates to True

Patches

fixed in 2c73f83

Severity

Moderate

CVE ID

CVE-2022-24787

Weaknesses

No CWEs