Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make importScripts() fail outside install #730

Closed
annevk opened this issue Aug 13, 2015 · 3 comments
Closed

Make importScripts() fail outside install #730

annevk opened this issue Aug 13, 2015 · 3 comments

Comments

@annevk
Copy link
Member

annevk commented Aug 13, 2015

I thought we had agreed that importScripts() should fail outside of installation? Otherwise we still have an unrestricted synchronous IO API...

@wanderview
Copy link
Member

It seems maybe "imported scripts updated flag" should be set at the end of the top level worker script evaluation instead of at the end of the first importScripts() call?

@jungkees
Copy link
Collaborator

Sorry that I had missed this part of the work. Addressed it: 0e021ef.

It seems maybe "imported scripts updated flag" should be set at the end of the top level worker script evaluation instead of at the end of the first importScripts() call?

Thanks for spotting this. I think the flag should be set only when all the importscripts(urls) have been successfully run without any runtime errors. So I put this step in the Install algorithm step 17.

@jungkees
Copy link
Collaborator

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants