Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review updates to vertical slider example page #230

Closed
7 tasks done
mcking65 opened this issue Dec 14, 2016 · 7 comments
Closed
7 tasks done

Review updates to vertical slider example page #230

mcking65 opened this issue Dec 14, 2016 · 7 comments
Assignees
@jongund @shirsha @annabbott
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

mcking65 commented Dec 14, 2016 •
edited
Loading

The following changes have been made to the
vertical slider example page:

  • Change page title to "Slider Examples with aria-orientation and aria-valuetext"
  • Make page title tag and H1 consistent.
  • Revise to use current example template
  • Write an introductory description.

Reviews Request as of March 11, 2017
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. needs edits labels Dec 14, 2016
@mcking65 mcking65 added this to the 1.1 PR milestone Dec 14, 2016
@mcking65 mcking65 modified the milestones: Feb 2017 Heartbeat Draft, 1.1 PR Jan 6, 2017
@jongund
Copy link
Contributor

jongund commented Feb 21, 2017

These issues should be fixed now, including JSCS errors, in the latest pull request

ZoeBijl pushed a commit that referenced this issue Feb 22, 2017
@jongund
Slider example update to fix issue #229 and #230
3b8c118 
- Update focus style
- Update page title
- Update description
- Fix JSCS bugs
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Feb 22, 2017

Thanks Jon! This issue is fixed in: 3b8c118

mcking65 added a commit that referenced this issue Mar 12, 2017
@mcking65
Slider Example with aria-orientation: Editorial Revisions
00e896d 
For issue #230, made following changes to  examples/slider/slider-2.html to make it  consistent with editorial guidelines and the template for examples:

1. Changed title to "Slider Examples with aria-orientation and aria-valuetext"
2. Made H1 consistent with title element.
3. Added link to review issue.
4. Added link to design pattern in intro paragraph and made editorial revisions and corrections.
5. Made editorial revisions and corrections to horizontal slider link and description.
6. Removed region role from example container.
7. Removed an H2 heading before the horizontal sliders and made all three sliders part of a single example container.
8. Added missing separator elements that mark the start and end of the example container for screen reader users.
9. Made editorial revisions to the keyboard table.
10. Made text of H2 for roles, states, and properties consistent with template.
11. Added a row for tabindex to the attributes table and made other editorial revisions and corrections.
12. Fixed href value of design pattern link in nav footer.
@mcking65 mcking65 changed the title Updates needed for vertical slider example page Review updates to vertical slider example page Mar 12, 2017
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern Needs Review labels Mar 12, 2017
@annabbott
Copy link

Looks good.

mcking65 pushed a commit that referenced this issue Mar 15, 2017
@jongund @mcking65
Slider Examples: Include tabindex in HTML and Improve Rail Focus Indi…
039ee3f 
…cator

For issues #229 and #230, In response to feedback from @mcking65 logged in issue #229, made the following changes for both slider example pages:

1. Include tabindex for thumbs in HTML; was previously added with javascript during instantiation.
2. Remove note about dynamic addition of tabindex from roles, states, and properties tables.
3. Improve focus styling of rail.
4. Removed un used CSS.
@shirsha
Copy link

shirsha commented Mar 16, 2017

It is working fine with keyboard only and with NVDA screen reader in Firefox.
With JAWS 18,17, in IE11 for the two horizontal sliders, it is not reading all the values when using up and down arrow.
It is working fine with right and left arrow.

Thanks,
Siri

@mcking65
Copy link
Contributor Author

Thank you @shirsha, yes, there are some JAWS bugs to report.

mcking65 added a commit that referenced this issue Mar 16, 2017
@mcking65
Close Review for Slider Examples with aria-orientation and aria-value…
48e0189 
…text

The review process for this example is now complete.

Modified examples/slider/slider-2.html to remove link to review issue #230.
@mcking65
Copy link
Contributor Author

All required reviews are complete and issues addressed. Thank you Team!

@a11ydoer
Copy link
Contributor

Thermostat with focus on vertical bar- adjustable doesnot work with swipe up or down

In iOS mobile device, thermostat vertical bar, temperature adjustment does not work with gesture. Touch has a little big of lag but adjustment works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

@shirsha shirsha

@annabbott annabbott

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
6 participants
@jongund @ZoeBijl @mcking65 @shirsha @a11ydoer @annabbott