Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify examples where the charCode property of keypress event is used #249

Closed
mcking65 opened this issue Jan 23, 2017 · 4 comments
Closed

Identify examples where the charCode property of keypress event is used #249

mcking65 opened this issue Jan 23, 2017 · 4 comments
Assignees
@a11ydoer
Labels
bug Code defects; not for inaccurate prose
Milestone
Jan 2017 Clean Up

Comments

@mcking65
Copy link
Contributor

mcking65 commented Jan 23, 2017 •
edited
Loading

The charCode proprety of keypress
is deprecated. This may be the reason that focus is trapped in the tree view examples when using later versions of Firefox as described in issue #223.

To facilitate plans to remove dependency on the charCode property of keypress event, Identify the examples that depend on it.
@mcking65 mcking65 changed the title Identify examples where keypress.charcode is used Identify examples where the charCode property of keypress event is used Jan 23, 2017
@mcking65 mcking65 added this to the Jan 2017 Clean Up milestone Jan 23, 2017
@mcking65 mcking65 added the bug Code defects; not for inaccurate prose label Jan 23, 2017
mcking65 pushed a commit that referenced this issue Jan 30, 2017
@jongund @mcking65
Merge pull request #263 from jongund/menu-button to remove keypress c…
50a45b3 
…harCode dependency

Addressess issue #249 for menu button examples.
@a11ydoer
Copy link
Contributor

a11ydoer commented Jan 30, 2017 •
edited
Loading

@mcking65
keypress code is located at
1)menubar examples - menuitmeaction.js and menuitemlinks.js
2)treeview examples - treeitem.js and tree.js

Jon has already fixed "key press" in menu button example.

@mcking65
Copy link
Contributor Author

Menubutton fix is in commit 50a45b3

mcking65 pushed a commit that referenced this issue Jan 31, 2017
@jongund @mcking65
removed keypress events for treeview examples
69a36ff 
* removed keypress events
* Addresses issue #249 for treeview examples.
@mcking65
Copy link
Contributor Author

Now, the only place where we still have this problem is in the menubar examples.

@mcking65
Copy link
Contributor Author

This issue is now resolved as follows:

  1. Fixed for menubutton example in commit 50a45b3
  2. Fixed for treeview examples in:
  3. Fixed for menubar examples in commit bbc4c09

@jongund, thank you very much for all your work on this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@a11ydoer a11ydoer

Labels
bug Code defects; not for inaccurate prose
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
2 participants
@mcking65 @a11ydoer