Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[html-aam PR 359] Change figure & figcaption accName computation #2224

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Commits on Jan 20, 2022

  1. Change figure & figcaption accName computation

    resolves #325
    
    This PR revises the mappings for `figure` and `figcaption` to remove the "labelled by" relations, changing them to "details for".
    The accessible name computation for `figure` removes `figcaption`, a note is added to further reference this change.
    
    TODO: 
    - [ ] need to check on updates to UIA mapping, if any.
    - [ ] do we want `figcaption` to map to `caption`? 
    - [ ] regardless of above, [`caption`](https://w3c.github.io/aria/#caption) will need to be updated in regards to its referencing `figure` and `figcaption` relationships
    - [ ] [`aria-details`](https://w3c.github.io/aria/#aria-details) definition should be updated to reference this change
    scottaohara authored Jan 20, 2022
    Configuration menu
    Copy the full SHA
    57dea71 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c247994 View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2022

  1. Configuration menu
    Copy the full SHA
    2cece28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    23f6eaa View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2022

  1. Configuration menu
    Copy the full SHA
    ada36a3 View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Configuration menu
    Copy the full SHA
    ec8d7de View commit details
    Browse the repository at this point in the history
  2. add in AX details for figure's relationship to figcaption

    cc @cookiecrook to make sure i got this right.  thank you
    scottaohara authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    1a6f853 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    379bca2 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    08499c6 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2022

  1. Configuration menu
    Copy the full SHA
    a2abcc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2022

  1. Configuration menu
    Copy the full SHA
    1cb01c6 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. finish up mapping detials

    verified the UIA mappings with help from @benbeaudry 
    made some of the wording consistent between mappings
    added in a SHOULD to indicate that if a figure is explicitly provided an accessible name from its figcaption, then do not expose the details relationship, as that'd add redundancy.
    scottaohara authored May 3, 2023
    Configuration menu
    Copy the full SHA
    be53256 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c8ad35 View commit details
    Browse the repository at this point in the history
  3. attempt to fix build error

    saying it doesn't know what accname is... so, replacing the instances of the links which may be causing the issue?
    scottaohara authored May 3, 2023
    Configuration menu
    Copy the full SHA
    0b40395 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    991db53 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d25c1ee View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0fe3c0b View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. Configuration menu
    Copy the full SHA
    ddc6a42 View commit details
    Browse the repository at this point in the history
  2. add comment regarding aria-details

    see https://bugs.chromium.org/p/chromium/issues/detail?id=1426613#c4
    
    aria-details with an empty string could be useful to authors if there was a specific need to _not_ expose a child figcaption - e.g., if the elements need to have remapped roles for whatever reason.
    scottaohara authored Jun 4, 2023
    Configuration menu
    Copy the full SHA
    69aca1e View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    c8c6aa8 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2023

  1. Configuration menu
    Copy the full SHA
    a50948b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d1da27 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    da867eb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. editorial: move html-aam PR359

    pkra committed May 24, 2024
    Configuration menu
    Copy the full SHA
    643fdec View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Configuration menu
    Copy the full SHA
    f7af218 View commit details
    Browse the repository at this point in the history
  2. chore: prettier

    scottaohara authored and actions-user committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    37d9ea8 View commit details
    Browse the repository at this point in the history
  3. further removals

    scottaohara authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    5bf314d View commit details
    Browse the repository at this point in the history