-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[html-aam PR 359] Change figure & figcaption accName computation #2224
Open
pkra
wants to merge
27
commits into
main
Choose a base branch
from
monorepo_history--html-aam-pr359
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Jan 20, 2022
-
Change figure & figcaption accName computation
resolves #325 This PR revises the mappings for `figure` and `figcaption` to remove the "labelled by" relations, changing them to "details for". The accessible name computation for `figure` removes `figcaption`, a note is added to further reference this change. TODO: - [ ] need to check on updates to UIA mapping, if any. - [ ] do we want `figcaption` to map to `caption`? - [ ] regardless of above, [`caption`](https://w3c.github.io/aria/#caption) will need to be updated in regards to its referencing `figure` and `figcaption` relationships - [ ] [`aria-details`](https://w3c.github.io/aria/#aria-details) definition should be updated to reference this change
Configuration menu - View commit details
-
Copy full SHA for 57dea71 - Browse repository at this point
Copy the full SHA 57dea71View commit details -
Configuration menu - View commit details
-
Copy full SHA for c247994 - Browse repository at this point
Copy the full SHA c247994View commit details
Commits on Feb 7, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 2cece28 - Browse repository at this point
Copy the full SHA 2cece28View commit details -
Configuration menu - View commit details
-
Copy full SHA for 23f6eaa - Browse repository at this point
Copy the full SHA 23f6eaaView commit details
Commits on Apr 4, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ada36a3 - Browse repository at this point
Copy the full SHA ada36a3View commit details
Commits on Apr 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ec8d7de - Browse repository at this point
Copy the full SHA ec8d7deView commit details -
add in AX details for figure's relationship to figcaption
cc @cookiecrook to make sure i got this right. thank you
Configuration menu - View commit details
-
Copy full SHA for 1a6f853 - Browse repository at this point
Copy the full SHA 1a6f853View commit details -
Configuration menu - View commit details
-
Copy full SHA for 379bca2 - Browse repository at this point
Copy the full SHA 379bca2View commit details
Commits on Jun 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 08499c6 - Browse repository at this point
Copy the full SHA 08499c6View commit details
Commits on Jul 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a2abcc5 - Browse repository at this point
Copy the full SHA a2abcc5View commit details
Commits on Oct 14, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1cb01c6 - Browse repository at this point
Copy the full SHA 1cb01c6View commit details
Commits on May 3, 2023
-
verified the UIA mappings with help from @benbeaudry made some of the wording consistent between mappings added in a SHOULD to indicate that if a figure is explicitly provided an accessible name from its figcaption, then do not expose the details relationship, as that'd add redundancy.
Configuration menu - View commit details
-
Copy full SHA for be53256 - Browse repository at this point
Copy the full SHA be53256View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9c8ad35 - Browse repository at this point
Copy the full SHA 9c8ad35View commit details -
saying it doesn't know what accname is... so, replacing the instances of the links which may be causing the issue?
Configuration menu - View commit details
-
Copy full SHA for 0b40395 - Browse repository at this point
Copy the full SHA 0b40395View commit details -
Configuration menu - View commit details
-
Copy full SHA for 991db53 - Browse repository at this point
Copy the full SHA 991db53View commit details -
Configuration menu - View commit details
-
Copy full SHA for d25c1ee - Browse repository at this point
Copy the full SHA d25c1eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0fe3c0b - Browse repository at this point
Copy the full SHA 0fe3c0bView commit details
Commits on Jun 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ddc6a42 - Browse repository at this point
Copy the full SHA ddc6a42View commit details -
add comment regarding aria-details
see https://bugs.chromium.org/p/chromium/issues/detail?id=1426613#c4 aria-details with an empty string could be useful to authors if there was a specific need to _not_ expose a child figcaption - e.g., if the elements need to have remapped roles for whatever reason.
Configuration menu - View commit details
-
Copy full SHA for 69aca1e - Browse repository at this point
Copy the full SHA 69aca1eView commit details
Commits on Oct 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c8c6aa8 - Browse repository at this point
Copy the full SHA c8c6aa8View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a50948b - Browse repository at this point
Copy the full SHA a50948bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d1da27 - Browse repository at this point
Copy the full SHA 2d1da27View commit details
Commits on Dec 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for da867eb - Browse repository at this point
Copy the full SHA da867ebView commit details
Commits on May 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 643fdec - Browse repository at this point
Copy the full SHA 643fdecView commit details
Commits on Sep 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f7af218 - Browse repository at this point
Copy the full SHA f7af218View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37d9ea8 - Browse repository at this point
Copy the full SHA 37d9ea8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bf314d - Browse repository at this point
Copy the full SHA 5bf314dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.