Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential support of structs in VSS #461

Closed
erikbosch opened this issue Nov 22, 2022 · 3 comments
Closed

Potential support of structs in VSS #461

erikbosch opened this issue Nov 22, 2022 · 3 comments

Comments

@erikbosch
Copy link
Contributor

For information, there are discussions in VSS to support structs. It could be an idea to discuss implications/expectations on VISS, so that we agree on how it might affect the standard and reference implementation. Potential topics:

  • Is it clear in current VSS spec how a structure will be represented as payload?
  • Other implications, willo it e.g. be possible to use filters on struct data?

References:

@UlfBj
Copy link
Contributor

UlfBj commented Nov 25, 2022

It is to my knowledge not clear, or discussed, how a struct should be represented in a payload.
I am not in favor of the paradigm to define structs using nodes in the tree. This will e. g. significantly increase the complexity of a tree parser.
Applying the filter model to struct data would add another dimension of complexity, as I see it.
My current view is that if this is to be supported, it will have to be in a coming version of VISS, not v2.

@tguild
Copy link
Member

tguild commented Apr 4, 2023

discussed on 2023-04-04 call, as struct is moving forward in VSS we should address here as well. Ulf to draft a solution to accommodate

@UlfBj
Copy link
Contributor

UlfBj commented Apr 18, 2023

Fixed in PR480

@UlfBj UlfBj closed this as completed Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants