Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-grid-3] if using display we should provide examples for inline masonry, and include the inline-masonry legacy fallback #10961

Open
keithamus opened this issue Sep 27, 2024 · 5 comments

Comments

@keithamus
Copy link
Member

keithamus commented Sep 27, 2024

As per title; I haven't seen examples of display: inline masonry. I also think should ensure to include the legacy inline-masonry keyword if we're using display.

@Loirooriol
Copy link
Contributor

We didn't add a legacy inline-list-item (dropped in #1495), block-ruby nor block-math (#5385), you need to provide 2 keywords for these combinations.

So I'm not convinced that we need inline-masonry, authors can just use inline masonry instead.

@bfgeek
Copy link

bfgeek commented Sep 27, 2024

So I'm not convinced that we need inline-masonry, authors can just use inline masonry instead.

We should add it as a convenience (there isn't any reason not to). E.g. most developers will use just inline-grid and not inline grid, and would be unnecessarily surprised if inline-masonry isn't supported. We shouldn't make this more difficult unnecessarily.

Ian

@keithamus
Copy link
Member Author

list-item is special and block is assumed; the only legacy variants are inline- prefixed. While
I’m indifferent about adding inline-masonry I was largely pointing it out for completeness otherwise IIRC it would be the only inside display value without an inline legacy variant.

@Loirooriol
Copy link
Contributor

We shouldn't call these "legacy" if we are going to keep adding them whenever we add new inside display types.

@Loirooriol
Copy link
Contributor

it would be the only inside display value without an inline legacy variant

Actually not, Houdini Layout adds layout() but not inline-layout().
It was removed by Ian in w3c/css-houdini-drafts@60ff1c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants