DeviceOrientationEvent: Define absolute's value on error #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were only requiring alpha, beta, and gamma to be null. It makes sense to also require implementations to set absolute to the same value as well. At the time of writing, this is done for completeness' sake though: - Blink implements this behavior and sets absolute to false when a deviceorientation cannot be provided, and to true for deviceorientationabsolute events. - Gecko does not send any events if it cannot provide readings (e.g. when there are no sensors available). - WebKit only ships an iOS implementation, whose IDL does not even have an absolute attribute. Fixes #119.
rakuco
pushed a commit
to rakuco/wpt
that referenced
this pull request
Feb 13, 2024
Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to.
|
Accompanying web test in web-platform-tests/wpt#44557 |
|
For posterity:
|
reillyeon
requested changes
Feb 13, 2024
reillyeon
approved these changes
Feb 14, 2024
rakuco
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 14, 2024
…ror (#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to.
github-actions bot
added a commit
that referenced
this pull request
Feb 14, 2024
SHA: c0f629e Reason: push, by rakuco Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 19, 2024
…nEvent's absolute value on error, a=testonly Automatic update from web-platform-tests orientation-event: Test DeviceOrientationEvent's absolute value on error (#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to. -- wpt-commits: fb4cd8f597e9b40725a51222b4627cbd6d94c528 wpt-pr: 44557
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Feb 20, 2024
…nEvent's absolute value on error, a=testonly Automatic update from web-platform-tests orientation-event: Test DeviceOrientationEvent's absolute value on error (#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to. -- wpt-commits: fb4cd8f597e9b40725a51222b4627cbd6d94c528 wpt-pr: 44557 UltraBlame original commit: 7ea0f73ea84b32a3a50b42e6058419b99f4b4bc6
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Feb 20, 2024
…nEvent's absolute value on error, a=testonly Automatic update from web-platform-tests orientation-event: Test DeviceOrientationEvent's absolute value on error (#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to. -- wpt-commits: fb4cd8f597e9b40725a51222b4627cbd6d94c528 wpt-pr: 44557
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2024
…ror (#44557) Test for w3c/deviceorientation#139. When a reading cannot be provided, `absolute` needs to be set accordingly depending on the event type we are listening to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only requiring alpha, beta, and gamma to be null. It makes sense to
also require implementations to set absolute to the same value as well.
At the time of writing, this is done for completeness' sake though:
deviceorientation cannot be provided, and to true for
deviceorientationabsolute events.
there are no sensors available).
absolute attribute.
Fixes #119.
Preview | Diff