Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JsonWebKey2020 to JsonWebKey #850

Open
decentralgabe opened this issue Feb 5, 2024 · 5 comments
Open

Update JsonWebKey2020 to JsonWebKey #850

decentralgabe opened this issue Feb 5, 2024 · 5 comments
Assignees
@msporny
Labels
class 3 Other changes that do not add new features pr exists There is an open PR to address this issue

Comments

@decentralgabe
Copy link
Contributor

As per https://w3c.github.io/vc-jose-cose/
@msporny msporny added the class 3 Other changes that do not add new features label Jul 1, 2024
@peacekeeper
Copy link
Contributor

Makes sense to align with VC specs.

@decentralgabe
Copy link
Contributor Author

As @msporny mentioned today we can either update the existing context or create a new one.
My guess is we'll probably need a new context for 1.1 anyway, so we could have this issue follow that one.
Alternatively, we could create a new examples context and solve this quicker.

I'm fine with either path.

@iherman
Copy link
Member

iherman commented Aug 9, 2024

My guess is we'll probably need a new context for 1.1 anyway

I am not so sure. I would not think we would add new properties for DID Documents (we may not even be allowed to do so), and that would be the only reason to change the context.

@decentralgabe decentralgabe mentioned this issue Aug 15, 2024
Open
@msporny msporny added the ready for pr Issue is ready for a PR label Sep 6, 2024
@pchampin
Copy link
Contributor

pchampin commented Sep 6, 2024

This was discussed during the did meeting on 2024-09-05:
https://www.w3.org/2024/09/05-did-minutes.html#t06

@msporny msporny self-assigned this Oct 30, 2024
@msporny msporny mentioned this issue Oct 30, 2024
Open
@msporny
Copy link
Member

msporny commented Oct 30, 2024

PR #867 has been raised to address this issue. This issue will be closed once PR #867 has been merged.

@msporny msporny added pr exists There is an open PR to address this issue and removed ready for pr Issue is ready for a PR labels Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
class 3 Other changes that do not add new features pr exists There is an open PR to address this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@msporny @peacekeeper @pchampin @iherman @decentralgabe