-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add event handler attributes (e.g. onkeystatuseschange on MediaKeySession) #176
Comments
Based on w3ctag/design-principles#29 (comment), we should have event handler attributes for all of our events. We need to add attributes for both
Of the
|
This is a clearly defined change that is ready for implementation. |
See w3c/html#335 (comment) for a detail you'll need to decide on. |
@foolip, does this only apply to the two @domenic said, "So I guess if it bubbles it belongs there." Related to bubbling, the spec text currently says:
Thus, it would seem there is no bubbling and thus no need to put these on the |
Yeah, all events in HTML are on I would go with extending |
@jdsmith3000, this is ready for implementation per the original plan. |
The original plan included adding attributes for MediaKeySession events:
And HTMLMediaElement events:
Please confirm that we now only need to add an attribute for onwaitingforkey to the HTMLMediaElement extensions. I'm preparing this change now. |
I don't believe anything has changed with respect to |
- MediaKeySession: Added onkeystatuschange and onmessage attributes - HTMLMediaElement: Added onwaitingforkey attribute and revised onencrypted attribute description to match the others, and the description used in MSE
Applied to onencrypted (as previous) and onwaitingforkey (new). Both are HTMLMediaElement attributes.
Fixed by 3d4a9ce. |
Justification is the same as in w3c/media-source#66 and this issue should probably block on the resolution of that.
The text was updated successfully, but these errors were encountered: