Better support for the accessibility vocab #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new EnumVocab constructors with a `CaseFormat` option to be able to define the rules from converting from the Enum constant to the property name. When not specified, the default case format is `LOWER_HYPHEN`. See https://google.github.io/guava/releases/snapshot/api/docs/com/google/common/base/CaseFormat.html - replace the `ENUM_TO_NAME` static function by a `Converter` class member (initialized based on the given case format) - add public methods `getName(P)` and `getNames(Collection<P>)` to get the string value of property names based on their Enum constant. - add tests for a vocab specifying the `LOWER_CAMEL` case format
- recognize `a11y` as a reserved prefix - define meta and link rel voabularies for Accessibility properties - add tests Fixes #810
rdeltour
added
the
status: needs review
mattgarrish
approved these changes
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility vocab
a11yas a reserved prefixFixes #810
EnumVocab API refactoring
CaseFormatoption to be able to define the rules from converting from the Enum constant to the property name. When not specified, the default case format isLOWER_HYPHEN.ENUM_TO_NAMEstatic function by aConverterclass member (initialized based on the given case format)getName(P)andgetNames(Collection<P>)to get the string value of property names based on their Enum constant.LOWER_CAMELcase format