Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type of sourceCharPosition attribute, and amend explainer #137

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Fix type of sourceCharPosition attribute, and amend explainer #137

merged 1 commit into from
Feb 16, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Feb 1, 2024 •
edited by pr-preview bot
Loading

@noamr noamr requested a review from tunetheweb February 1, 2024 10:32
@noamr noamr closed this Feb 16, 2024
@noamr noamr reopened this Feb 16, 2024
@noamr noamr requested a review from clelland February 16, 2024 15:20
clelland
clelland approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@clelland clelland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr noamr merged commit ee95837 into main Feb 16, 2024
5 checks passed
@noamr noamr deleted the source-loc branch February 16, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clelland clelland clelland approved these changes

@tunetheweb tunetheweb Awaiting requested review from tunetheweb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noamr @clelland