Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying visual effects #162

Closed
chrishtr opened this issue Dec 19, 2019 · 10 comments
Closed

Applying visual effects #162

chrishtr opened this issue Dec 19, 2019 · 10 comments

Comments

@chrishtr
Copy link

Has there been any discussion of what to do when transform, filter, opacity, blend-mode, clip-path, clip, etc are applied to a MathML element?

This is very related to the containing block and stacking context discussion (e.g. #74).

@fred-wang
Copy link
Contributor

@chrishtr Hi, sorry this was posted during vacations and I missed it. I don't think we had any discussion in the CG but my personal opinion is that we should probably support them if possible. I think @bfgeek had already mentioned them somewhere.

@fred-wang
Copy link
Contributor

I didn't mention it here, but in order to address #130 a section was added saying that basically all MathML elements generate a stacking context: https://mathml-refresh.github.io/mathml-core/#stacking-contexts

I'm not sure if these effects are really important for math formulas, but I wouldn't surprised if someone wants to use them (at least opacity) and if they are already supported by webkit or gecko. IIUC, @bfgeek said it's easier to just allow these properties that to disable them.

Also I don't know if that's included in this issue, but at least I used linear-gradient on an mrow element some years ago for https://fred-wang.github.io/MathFonts/STIX/index.html and it's working in all browsers.

@rwlbuis
Copy link
Contributor

rwlbuis commented Aug 3, 2020

Going to experiment... Expectation is that nothing/not much needs to be added to the specification about this, but we need tests for sure.

@NSoiffer
Copy link
Contributor

NSoiffer commented Aug 3, 2020

For the record, from the MathML Core meeting today:
NS: Seems like we need to write tests and see what the implementation is doing. Do they just flow through or do we need to have the UA stylesheet for math reset some of them?
BM: Seems like we need more abstract language so we don’t have to list every potential interaction. Probably requires someone with deep knowledge of the web to know which things fall into what categories… if there are different categories of effects.
BK: we need to know where it is special, such as creating a new stacking context.

Bottom line is that people generally felt they should work unless there is some reason they shouldn't work such as messing up the implementation.

@rwlbuis
Copy link
Contributor

rwlbuis commented Aug 10, 2020

So far my experiments showed up no problems. Still need to add a test for opacity I think.

@NSoiffer
Copy link
Contributor

Based on comment by @rwlbuis at the core meeting today, there don't appear to be any problems with supporting transforms. Some more tests probably need to be added and Rob will check with google about what they think should be tested.

@rwlbuis
Copy link
Contributor

rwlbuis commented Sep 21, 2020

@chrishtr Several subtests landed here:
web-platform-tests/wpt@9b98f40
can you think of more visual effects to test? As mentioned before I don't think we want tests for all ~11 css filters...

moz-v2v-gh referenced this issue in mozilla/gecko-dev Sep 23, 2020
…nt, a=testonly

Automatic update from web-platform-tests
Test some visual effects on MathML content (#24935)

See https://github.com/mathml-refresh/mathml/issues/179.
--

wpt-commits: 9b98f401e54a7acf9f2dc889318ee7c5d56c1263
wpt-pr: 24935
sidvishnoi referenced this issue in sidvishnoi/gecko-webmonetization Sep 24, 2020
…nt, a=testonly

Automatic update from web-platform-tests
Test some visual effects on MathML content (#24935)

See https://github.com/mathml-refresh/mathml/issues/179.
--

wpt-commits: 9b98f401e54a7acf9f2dc889318ee7c5d56c1263
wpt-pr: 24935
gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified-and-comments-removed Sep 28, 2020
…nt, a=testonly

Automatic update from web-platform-tests
Test some visual effects on MathML content (#24935)

See https://github.com/mathml-refresh/mathml/issues/179.
--

wpt-commits: 9b98f401e54a7acf9f2dc889318ee7c5d56c1263
wpt-pr: 24935

UltraBlame original commit: e906ea5fd219483619deb8b5e9d2e8cf1fa205dd
gecko-dev-updater referenced this issue in marco-c/gecko-dev-comments-removed Sep 28, 2020
…nt, a=testonly

Automatic update from web-platform-tests
Test some visual effects on MathML content (#24935)

See https://github.com/mathml-refresh/mathml/issues/179.
--

wpt-commits: 9b98f401e54a7acf9f2dc889318ee7c5d56c1263
wpt-pr: 24935

UltraBlame original commit: e906ea5fd219483619deb8b5e9d2e8cf1fa205dd
gecko-dev-updater referenced this issue in marco-c/gecko-dev-wordified Sep 28, 2020
…nt, a=testonly

Automatic update from web-platform-tests
Test some visual effects on MathML content (#24935)

See https://github.com/mathml-refresh/mathml/issues/179.
--

wpt-commits: 9b98f401e54a7acf9f2dc889318ee7c5d56c1263
wpt-pr: 24935

UltraBlame original commit: e906ea5fd219483619deb8b5e9d2e8cf1fa205dd
@davidcarlisle
Copy link
Collaborator

Should ths issue be moved to mathml-core?

@NSoiffer
Copy link
Contributor

Yes

@davidcarlisle davidcarlisle transferred this issue from w3c/mathml Aug 16, 2022
@bkardell
Copy link
Collaborator

As resolved today in the meeting: We believe the issues referred to in the OP ( containing block and stacking context discussion) were fixed and that many tests have been added since. These visual effects should now just work, but if @chrishtr feels that we still need additional tests, please feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants