Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xr-spatial-tracking enum value + entry #254

Merged
merged 2 commits into from
Aug 26, 2021
Merged

Add xr-spatial-tracking enum value + entry #254

merged 2 commits into from
Aug 26, 2021

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented Jul 26, 2021

closes #108

The following tasks have been completed:

Implementation commitment:

  • WebKit - implemented as a permission policy, but Permissions API is not yet implemented
  • Blink - implemented
  • Gecko - implemented, but experimental

Preview | Diff

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Jul 26, 2021

Gecko seems to implements this, but not through the Permissions API:
https://searchfox.org/mozilla-central/source/dom/vr/XRPermissionRequest.cpp

At least, they are not hooked up together.

@cabanier or @Manishearth, do you know if folks at Mozilla is still working on XR?

@cabanier
Copy link
Member

do you know if folks at Mozilla is still working on XR?

I do not. Maybe @jdashg knows?

@Manishearth
Copy link
Member

I don't think so. But unsure.

@kdashg
Copy link

kdashg commented Jul 26, 2021

It's roughly-speaking in maintenance mode: No one is actively working on it, but neither is it removed.

@marcoscaceres
Copy link
Member Author

Ok, thanks @jdashg! I might poke at it, and see if I can get it to pick up the permission though the API.

@marcoscaceres
Copy link
Member Author

marcoscaceres commented Aug 19, 2021

In WebKit, I think this is called "xr-spatial-tracking"? https://immersive-web.github.io/webxr/#permissions-policy

@marcoscaceres marcoscaceres changed the title Add xr enum value + entry Add xr-spatial-tracking enum value + entry Aug 24, 2021
@marcoscaceres
Copy link
Member Author

Gecko has it in the experimental set:
https://searchfox.org/mozilla-central/source/dom/security/featurepolicy/FeaturePolicyUtils.cpp#58

Given that it's across all three, I'm merging.

@marcoscaceres
Copy link
Member Author

Tested in web-platform-tests/wpt#30189

@marcoscaceres marcoscaceres merged commit 37db6ae into main Aug 26, 2021
github-actions bot added a commit that referenced this pull request Aug 26, 2021
SHA: 37db6ae
Reason: push, by @marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'webvr' to "Permission Registry" enum
4 participants