-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require transient activation #351
base: gh-pages
Are you sure you want to change the base?
Conversation
Updated tests ... web-platform-tests/wpt#36122 |
To make this change in Chromium we should do analysis of the compatibility impact and announce a deprecation. It looks like requiring transient activation is not a normative requirement for the |
Sorry, I wasn't very clear. The transient activation aspect I was referring to was the act of pressing the play button.
Yes, exactly that. That's to allow the video to play with audio, even though it's silent (Safari detects it a video that's making noise). |
Ok, we've updated WebKit to not consume user activation. |
Send a PR with an isolated test web-platform-tests/wpt#36152 @reillyeon, wrote:
Ok, no problem. WebKit will probably ship requiring transient activation. I think we are willing to take the compat hit as otherwise we feel the API might be too easy to abuse. |
Closing based on @anssiko comment #326 (comment) Can someone please take this up though? 🙏 |
This will be used to understand the compatibility impact of adding a transient activation requirement as proposed in w3c/screen-wake-lock#351. Bug: 1370132 Change-Id: Iff35979eef46d640aaf8b8f6a336546c03ff0355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3928945 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1053843}
This will be used to understand the compatibility impact of adding a transient activation requirement as proposed in w3c/screen-wake-lock#351. Bug: 1370132 Change-Id: Iff35979eef46d640aaf8b8f6a336546c03ff0355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3928945 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by: Raphael Kubo Da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1053843} NOKEYCHECK=True GitOrigin-RevId: 7d6b065bce749cfa333b506fca5db81245036ec7
Is WebKit open to switching to a sticky activation model? Chromium's metrics look better for that and it means that a site can reacquire a lock if it had one before but lost it due to visibility changes. |
Closes #350
The following tasks have been completed:
Implementation commitment:
Preview | Diff