Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracestate ows example fails before exercising service #341

Closed
toumorokoshi opened this issue Oct 20, 2019 · 1 comment
Closed

tracestate ows example fails before exercising service #341

toumorokoshi opened this issue Oct 20, 2019 · 1 comment
Assignees

Comments

@toumorokoshi
Copy link

toumorokoshi commented Oct 20, 2019

the test_tracestate_ows_handling raises a ValueError before exercising the service under test:

https://github.com/w3c/trace-context/blob/master/test/test.py#L640

The exception that is raised is:

Traceback (most recent call last):
  File "test.py", line 640, in test_tracestate_ows_handling
    ['tracestate', 'foo=1 '],
  File "test.py", line 113, in make_single_request_and_get_tracecontext
    return (self.get_traceparent(headers), self.get_tracestate(headers))
  File "test.py", line 108, in get_tracestate
    tracestate.from_string(value)
  File "/home/tsutsumi/workspace/opentelemetry-python/target/trace-context/test/tracecontext/tracestate.py", line 54, in from_string
    raise ValueError('illegal key-value format {!r}'.format(member))
ValueError: illegal key-value format 'foo=1 '
@reyang
Copy link
Contributor

reyang commented Oct 21, 2019

The error means the service being tested is not stripping training spaces in tracestate while calling back to the test harness.

@reyang reyang closed this as completed Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants