Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance clauses are missing, wrong or inconsistent #440

Closed
David-Chadwick opened this issue Mar 5, 2019 · 3 comments
Closed

Conformance clauses are missing, wrong or inconsistent #440

David-Chadwick opened this issue Mar 5, 2019 · 3 comments
Assignees

Comments

@David-Chadwick
Copy link
Contributor

Reviewing the conformance statements (MUST, MAY, SHOULD) in the normative sections of the data model has revealed the following problems:

  1. The following properties have no conformance statement: credentialSubject, @context, issuer, refreshService, evidence, credentialSchema
  2. The following sections have inconsistencies: 4.3 on types lists the properties that must have types but does not include all the properties that must have types, proof and JWT encoding,
  3. The following properties have wrong conformance statements: type, credentialStatus, expirationDate, termsOfUse
@jonnycrunch
Copy link
Contributor

related to #421 (comment)

@brentzundel
Copy link
Member

This issue has been addressed by PR #443

@msporny
Copy link
Member

msporny commented Mar 15, 2019

PR #443 has been merged. Closing this issue as the updated conformance statements written by @David-Chadwick and refined by @brentzundel and @msporny are in the spec now. Reopen if you disagree.

@msporny msporny closed this as completed Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants