Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feedDisplay images transform #225

Closed
howard-e opened this issue Jun 6, 2023 · 2 comments · Fixed by #245
Closed

Remove feedDisplay images transform #225

howard-e opened this issue Jun 6, 2023 · 2 comments · Fixed by #245
Assignees
Labels
bug Something isn't working Infrastructure

Comments

@howard-e
Copy link
Contributor

howard-e commented Jun 6, 2023

#190 describes the rating images for the feed's display example failing to load. #224 implements a stopgap fix to address this concern.

This should only be temporary until further research is looked into for how the we can package the image assets together with the feed display's content, when creating the Jekyll build that's deployed on the WAI website.

@mcking65
Copy link
Contributor

@howard-e

Now that w3c/aria-practices#2729 is merged, this issue can be resolved.

@howard-e
Copy link
Contributor Author

howard-e commented Jul 31, 2023

@howard-e

Now that w3c/aria-practices#2729 is merged, this issue can be resolved.

@mcking65 I've submitted #245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants