Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For publication / deploy on Tuesday December 18, 2023 #288

Merged
merged 5 commits into from
Dec 19, 2023
Merged

Conversation

howard-e
Copy link
Contributor

Hi @shawna-slh. We would like to deploy a new version of the APG as requested by @mcking65 through a recent email thread.

The update includes the following, as sourced from the December 12, 17 and 18, 2023 w3c#aria-practices commits and a subset of the items listed under Status of Site Updates > PRs target for Dec 18 publication:


Infrastructure: Fix inconsistencies in lists of CSS and JS files on 3 example pages (Related to wai-aria-practices issue 255) (pull #2883)

By alflennik on Dec 12, 2023

Each example page has a list of CSS and JS files used by the sourceCode function in shared/js/examples.js. Three examples had errors in this list that are corrected by this commit. This fix supports resolution of w3c/wai-aria-practices#255, which is related to incorrect last revision dates being shown in the footer of example pages.

View commit b2cae7f


Menu button pattern and 4 examples: Set aria-expanded to false when menus are closed (pull #2839)

By andreancardona on Dec 17, 2023

Closes issues #697 and #2834 with the following changes: * Revise menu button pattern to specify that aria-expanded is set to false when the menu is not displayed. * Revise JS and documentation for 3 menu button examples and the toolbar example to set aria-expanded false when their menus are closed. * Adjusts corresponding regression tests to ensure the state of expanded is true when the menus are open and false when the menus are closed.

View commit 9be3825


Accessible Names Practice: Recommend association via 'for' attribute when using 'label' element (pull #2882)

By mcking65 on Dec 18, 2023

Resolves issue #2870 by revising the content of the section describing usage of the HTML label element. Revisions include: 1. Move description of the for attribute technique before the description of the encapsulation technique. 2. Note that using the for attribute is known as 'explicit association' and using encapsulation is known as 'implicit association'. 3. State that explicit association has better AT/browser support than implicit association.

View commit 966c4ca


Rating Slider Example: Redesign as an input for 10-value satisfaction scale (pull #2831)

By jongund on Dec 18, 2023

Resolves issue #2501 by modifying the rating slider example as follows: * Changes it to a 10-point scale from a 5-star scale that had half star ratings. * Changes the visual design to better represent common 10-point satisfaction sliders. * Improves the high contrast support. * Adds documentation that explains why the slider pattern is appropriate for this use case.

View commit 7f54d96

Copy link

netlify bot commented Dec 18, 2023

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit ba0a291
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/6580a41976124d0008ab2d8f
😎 Deploy Preview https://deploy-preview-288--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e
Copy link
Contributor Author

cc @mcking65 @a11ydoer @ccanash

@shawna-slh shawna-slh merged commit b7d6db5 into publication Dec 19, 2023
7 checks passed
@a11ydoer
Copy link

@shawna-slh Thanks and Happy holidays! (This marks the final publication of the APG for the current calendar year.)

@shawna-slh
Copy link
Contributor

/me checks https://www.w3.org/WAI/ARIA/apg/patterns/accordion/examples/accordion/ and sees date updated.

@howard-e other updates look good?

@howard-e
Copy link
Contributor Author

Thanks @shawna-slh! Looks good to me as well. I can confirm the recent content changes to the following pages are also there:

cc @mcking65 @a11ydoer the site seems to be updated so please also confirm the expected changes are there. Happy we could get this in before the end of the year!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants