For publication / deploy on Tuesday February 27, 2024 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix last modified date issue
* Update formatForJekyll.js to expliclity look for data-skipto properties * Remove need for dataSkipTo attribute being passed to formatForJekyll.js * Update formatForJekyll.js to only include skipto.js once with any applicable data attribs; update transformHomepage.js to remove conflicting style tag
✅ Deploy Preview for aria-practices ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
cc @mcking65 @a11ydoer @ccanash w3c/aria-practices#2936 may also be pushed later today or early tomorrow to also be included in this publication. Which, from the perspective of this deploy will update the date shown for the Coverage and Quality Reports page to a more recent date because w3c/aria-practices#2122 included above already includes a date, but older. |
|
ack. I can publish on Tuesday. (I did only cursory skim, not thorough review) |
howard-e
changed the title
|
hi @howard-e @daniel-montalvo @mcking65 @a11ydoer @ccanash Deployed. You might need to do hard refresh. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @shawna-slh. We would like to deploy a new version of the APG. This was approved during last week's APG meeting
The update includes the following, as sourced from February 20 2024 Agenda > Next publication and recent w3c#aria-practices commits:
Infrastructure: update skipto.js to version 5.2.1 (pull #2807)
By jongund on Feb 13, 2024
Updates skipto.js to use version 5.2.1 without APG specific modifications.
In lieu of modifying the script, the script import now specifies parameters for the desired behaviors.
This required changing the script import on every page to include the following data attribute:
<script data-skipto="colortheme: aria; displayoption: popup" src="../../shared/js/skipto.js"></script>This is related to issue 259 in wai-aria-practices repository.
Co-authored-by: Matt King a11yThinker@gmail.com
Co-authored-by: Howard Edwards howarde.edwards@gmail.com
View commit 5446c67
Infrastructure: Automatically update coverage and quality report on merge (pull #2122)
By nschonni on Feb 20, 2024
Closes #2061
Co-authored-by: ariellalgilmore ariellalgilmore@gmail.com
Co-authored-by: Matt King a11yThinker@gmail.com
View commit 16dbe83
Infrastructure: Fix failing link checker on GitHub README link (pull #2931)
By evmiguel on Feb 26, 2024
Closes #2907
View commit 829499f
Sortable Table Example: Improve CSS so it works when all columns are sortable (pull #2910)
By kentslaney on Feb 26, 2024
Fix issue w3c/aria-practices#2904: Ensure that the TH height is sufficient if the table is changed to make all the columns sortable.
View commit 81d807d