Clarify distinction between PublicKeyCredentialUserEntity name and displayName #1932
+15
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbweeden
reviewed
Jul 26, 2023
MasterKale
changed the title
nicksteele
approved these changes
Aug 1, 2023
emlun
reviewed
Aug 2, 2023
emlun
approved these changes
Aug 3, 2023
akshayku
approved these changes
Aug 9, 2023
MasterKale
commented
Aug 9, 2023
akshayku
reviewed
Aug 9, 2023
emlun
requested changes
Aug 16, 2023
agl
reviewed
Aug 16, 2023
emlun
approved these changes
Aug 31, 2023
github-actions bot
added a commit
that referenced
this pull request
Sep 12, 2023
SHA: 58d60d0 Reason: push, by MasterKale Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to help RP's understand the differences between
user.nameanduser.displayName. It most importantly establishesuser.nameas the primary value displayed by browsers to users. The definition ofuser.displayNamehas also been tweaked to emphasize that this value has utility to differentiate "sub-accounts" for a givenuser.name, but without encouraging its use as based on observations I made back in February only Android currently exposes this value.Fixes #1852.
Preview | Diff