-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is codec.sdpFmtpLine present when there is no fmtp line in the SDP? #779
Comments
fippo
changed the title
Is codec.sdpFmtpLine present when there is no sdpFmtpLine in the SDP?
Is codec.sdpFmtpLine present when there is no fmtp line in the SDP?
Jan 24, 2024
It's a dictionary, so omitting members is allowed, and I think it should be required to omit it when there is no fmtp line. (If there's "a=fmtp:96:" in the SDP, there should be an empty string there, of course.) |
oh we have that special-case of empty fmtp line for stats too courtesy of @dontcallmedom! |
fippo
added a commit
to fippo/webrtc-stats
that referenced
this issue
Jan 25, 2024
henbos
pushed a commit
that referenced
this issue
Jan 25, 2024
* clarify that sdpFmtpLine may not be there fixes #779 * remove JSEP alias * Update webrtc-stats.html Co-authored-by: Philipp Hancke <fippo@goodadvice.pages.de> --------- Co-authored-by: Harald Alvestrand <hta+github@alvestrand.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Which is typically the case for VP8 which has no parameters. In Chrome this leads to
while sdpFmtpLine is defined as
here.
It seems like this should only exist when the codec has a fmtp line? No code changes required but we might need some WPT updates.
The text was updated successfully, but these errors were encountered: